Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: clip as external executor #74

Merged
merged 13 commits into from Aug 8, 2022
Merged

feat: clip as external executor #74

merged 13 commits into from Aug 8, 2022

Conversation

delgermurun
Copy link
Contributor

@delgermurun delgermurun commented Aug 3, 2022 •
edited

Related PR on upstream dependency

@delgermurun delgermurun marked this pull request as ready for review August 3, 2022 18:38
numb3r3
numb3r3 requested changes Aug 4, 2022
View reviewed changes
flow.yml Show resolved Hide resolved
JoanFM
JoanFM reviewed Aug 4, 2022
View reviewed changes
flow.yml Outdated Show resolved Hide resolved
JoanFM
JoanFM requested changes Aug 4, 2022
View reviewed changes
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does diffusion make sense to be async now that no client to clip is involved?

@delgermurun
Copy link
Contributor Author

Does diffusion make sense to be async now that no client to clip is involved?

yeah, async no longer makes sense. Removing it...

JoanFM
JoanFM reviewed Aug 4, 2022
View reviewed changes
executors/glid3/executor.py Outdated Show resolved Hide resolved
@delgermurun delgermurun requested a review from JoanFM August 4, 2022 16:02
JoanFM
JoanFM requested changes Aug 5, 2022
View reviewed changes
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think diffusion should receive cas address from yaml

executors/glid3/executor.py Outdated Show resolved Hide resolved
@delgermurun delgermurun requested a review from JoanFM August 5, 2022 12:30
JoanFM
JoanFM requested changes Aug 5, 2022
View reviewed changes
flow.yml Outdated Show resolved Hide resolved
@delgermurun delgermurun requested a review from JoanFM August 5, 2022 16:05
@delgermurun delgermurun force-pushed the feat-clip-as-external-executor branch from f79e120 to 2e789a4 Compare August 8, 2022 07:28
@delgermurun delgermurun force-pushed the feat-clip-as-external-executor branch from 20efff6 to 659750f Compare August 8, 2022 09:09
@delgermurun delgermurun merged commit 55a379e into main Aug 8, 2022
@delgermurun delgermurun deleted the feat-clip-as-external-executor branch August 8, 2022 09:12
@delgermurun delgermurun restored the feat-clip-as-external-executor branch August 8, 2022 09:47
delgermurun added a commit that referenced this pull request Aug 8, 2022
@delgermurun
Revert "feat: clip as external executor (#74)"
df12eeb 
This reverts commit 55a379e.
@delgermurun delgermurun mentioned this pull request Aug 8, 2022
Merged
delgermurun added a commit that referenced this pull request Aug 8, 2022
@delgermurun
Revert "feat: clip as external executor (#74)" (#78)
7bae6c8 
This reverts commit 55a379e.
@delgermurun delgermurun deleted the feat-clip-as-external-executor branch August 8, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao Awaiting requested review from hanxiao

@samsja samsja Awaiting requested review from samsja

@numb3r3 numb3r3 Awaiting requested review from numb3r3

@JoanFM JoanFM Awaiting requested review from JoanFM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delgermurun @JoanFM @numb3r3